Checklist metadata validation and checklist mapper severities #2750
Conversation
Signed-off-by: kemley76 <[email protected]>
Signed-off-by: kemley76 <[email protected]>
Signed-off-by: kemley76 <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
…n error message Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
…tion Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
…none Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
src/utils/ohdf/types.ts
Outdated
| */ | ||
| export type RowType = 'total' | 'critical' | 'high' | 'medium' | 'low' | 'Not Applicable'; | ||
| export type RowType = 'total' | 'critical' | 'high' | 'medium' | 'low' | 'none'; |
There was a problem hiding this comment.
i'm not familiar enough with threshold files to know if the changes you're making here are appropriate. please get @aaronlippold / @wdower / @ejaronne to confirm if this is alright.
There was a problem hiding this comment.
Had a discussion with @aaronlippold and @wdower regarding this table. There is no need to have a row for severity "none" because it should not be possible for there to be severity "none". Every mapper should define a severity, especially in the case when status is not applicable, because then impact would be 0 leading to severity "none".
I have reverted my changes, but the option for RowType: 'Not Applicable' has been removed because it is never used and does not need to be used because there is a column that represents this.
The script that generates this kind of table may need to be updated to reflect the possibility of there being N/A controls with severity critical, high, medium, or low.
There was a problem hiding this comment.
Please make a new issue for this task @kemley76
Signed-off-by: Kaden Emley <[email protected]>
|
This pull request has a conflict. Could you fix it @kemley76? |
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
Signed-off-by: Kaden Emley <[email protected]>
|
Combines #2716 and #2637 into one PR due to many overlapping changes. Bringes in features and updates tests from Heimdall changes regarding checklist mapping and severity levels and checklist metadata validation.